search

JeemyJohn / AnomalyDetection

Anomaly Detection Algorithms with Java
http://blog.csdn.net/u013709270
Apache License 2.0
201 stars 46 forks source link

code review #1

Open jayixl opened 7 years ago

jayixl commented 7 years ago

你这个代码有好多问题，我随便列几个

  1. .idea文件等代码、配置无关的文件不要checkin；
  2. package的层次还不够好；
  3. I**的方式一般是用来定义接口的，而不是class；定义接口是个好习惯，应该另行起class实现接口；
  4. 测试一般不要写在某个class的main函数里，用junit
chenxofhit commented 5 years ago

The author just emphasizes the implementation of the algorithm in java itself but not the engineering. @jayixl Perhaps you are right if you pursue the code implementation accroding to some kind of programming language.