search

JeetShetty / GreenPiThumb

https://mtlynch.io/greenpithumb/
Apache License 2.0
82 stars 12 forks source link

Pre-commit hook doesn't block on YAPF diff #131

Closed mtlynch closed 7 years ago

mtlynch commented 7 years ago

The pre-commit hook should block the commit if the YAPF diff turns up a delta, but currently it seems to just print a message and keep going. We should change the build so that it returns a failing exit code on a non-zero diff.

mtlynch commented 7 years ago

Apparently this is a behavior change in YAPF:

https://github.com/google/yapf/issues/325

They're considering a fix, but there's a workaround possible:

https://github.com/google/yapf/issues/325#issuecomment-261552890