Fix Recording Date Serialization Test

JeevanJames / Id3

Library to read, modify and write ID3 & Lyrics3 tags in MP3 files. Provides an extensible framework for retrieving ID3 information from online services.

Apache License 2.0

41 stars 17 forks source link

Fix Recording Date Serialization Test #27

Open spottedmahn opened 4 years ago

JeevanJames commented 4 years ago

I believe this change does not comply with the ID3 v2.3 spec.

Per the spec, the recording date (TDAT frame) should be in the format DDMM. This frame is complimented by the TYER and TIME frames for the recording year and time.

The only other recording date frame is the TRDA frame (recording dates), but that is a free text frame, so does not need format validation.

Could you clarify the reason behind this change? Are you facing issues with a specific player?

spottedmahn commented 4 years ago

I believe this change does not comply with the ID3 v2.3 spec.

Oh, interesting.

Could you clarify the reason behind this change? Are you facing issues with a specific player?

This test was failing: https://github.com/JeevanJames/Id3/blob/4ce257697963517585fba2f4ff6abe8f1eee1431/test/Id3.Net.Tests/SerializationTests.cs#L33

spottedmahn commented 4 years ago

line 69: Assert.Equal(tag.RecordingDate.Value, clonedTag.RecordingDate.Value);