search

Jeff-Lewis / cls-hooked

cls-hooked : CLS using AsynWrap or async_hooks instead of async-listener for node 4.7+
BSD 2-Clause "Simplified" License
758 stars 89 forks source link

Memory leak in Node 8.9.3 #49

Closed WingMrL closed 4 years ago

WingMrL commented 4 years ago

I'm using Node: 8.9.3, cls-hooked: ^4.2.2.

There's the memory snapshoot: image

I found this: image

async hooks promise not destroyed

Certainly，I update Node to version 8.15.0。No memory leak any more.

So, cls-hooked dependency, Node version should update to the right version instead of 8.2.1

WingMrL commented 4 years ago

Oh I found that this memory leak is not caused by cls-hooked。I found the real reason: https://github.com/nodejs/node/pull/23410