Jeff-Lewis / openid-selector

Automatically exported from code.google.com/p/openid-selector
0 stars 0 forks source link

Patch for the sed directive #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Take version 1.3 of February 2011

What steps will reproduce the problem?
1. Uncomment technorati, launchpad, etc.
2. Run generate-sprite.sh on Ubuntu 11.10
3. Fails with errors

The problem is this line:
./remcomments.sed < ${JSFILE} | sed -n '/providers_large/,/;/p' | sed -n '/: 
{/p' | sed 's/.*\t\(.*\) : {/\1/'  > tmp.txt

It should be extended by
| sed 's/://g;s/{//g;' | tr -d '[:blank:]'

making it 
./remcomments.sed < ${JSFILE} | sed -n '/providers_large/,/;/p' | sed -n '/: 
{/p' | sed 's/.*\t\(.*\) : {/\1/' | sed 's/://g;s/{//g;' | tr -d '[:blank:]' > 
tmp.txt

Else there are whitespaces and } and : in the result, instead of just a list of 
names for the images...

Original issue reported on code.google.com by stefan.m...@gmail.com on 30 Nov 2011 at 9:59

GoogleCodeExporter commented 9 years ago
This also applies for providers_small of course, which should be:
./remcomments.sed < ${JSFILE} | sed -n '/providers_small/,/;/p' | sed -n '/: 
{/p' | sed 's/.*\t\(.*\) : {/\1/' | sed 's/://g;s/{//g;' | tr -d '[:blank:]' > 
tmp.txt

Original comment by stefan.m...@gmail.com on 30 Nov 2011 at 10:00

GoogleCodeExporter commented 9 years ago
committed into SVN

Original comment by andriy.gerasika on 16 Apr 2012 at 1:22