Jeff-Lewis / vosao

Automatically exported from code.google.com/p/vosao
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Download servlet too slow #595

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. add various files and folder to non static resources 
2. download a non static resource. ie /file/theme/coolblue10/jquery.js
3. the RPC count hits 2500 and elapsed time is 7000ms

What is the expected output? What do you see instead?

the RPC should be <10 and elapsed time 200ms

Please use labels and text to provide additional information.

this issue is with the folder.getTree which is continually checking the entire 
tree for isaccessDenied which is NOT required.

Original issue reported on code.google.com by lucio.pi...@gmail.com on 4 Nov 2013 at 1:35

GoogleCodeExporter commented 9 years ago
changed DownloadServlet to only fetch the folder that contains file to be 
downloaded.
This has reduced RPC to 30 and elapse time 200-300ms.
further improvement can be don to reduce 30 RPC calls.

r1150  

Original comment by lucio.pi...@gmail.com on 4 Nov 2013 at 1:37

GoogleCodeExporter commented 9 years ago
Have imported your changes but the debugger doesn't hit the breakpoint.
I guess, I had stopped uploading CSS and images a while ago, because of these 
problems.
Do you know the root cause for the timeouts though?
I've noticed lately a lot of errors, with other GET calls

Original comment by theb...@emanueleziglioli.it on 5 Nov 2013 at 11:11

GoogleCodeExporter commented 9 years ago
the code will only be invovked if
1. doing a GET on non static resource stored on vosao
2. file is NOT in memecache

if your resources are stored offsite or in cache then this wont be executed.

hope that helps

Original comment by lucio.pi...@gmail.com on 6 Nov 2013 at 5:26