Potential unintentional overwrite of children list

Jeff-sjtu / HybrIK

Official code of "HybrIK: A Hybrid Analytical-Neural Inverse Kinematics Solution for 3D Human Pose and Shape Estimation", CVPR 2021

MIT License

1.24k stars 149 forks source link

Potential unintentional overwrite of children list #16

Open rubenvillegas opened 3 years ago

rubenvillegas commented 3 years ago

Looks like the "-3" used to rotate joints that have 3 children is overwritten here: https://github.com/Jeff-sjtu/HybrIK/blob/e10afb149e10cf721b619b12eb81f02b7ad3c4e0/hybrik/models/layers/smpl/SMPL.py#L160

Is this on purpose?

Jeff-sjtu commented 3 years ago

Hi, this actually works for both cases. When setting it to neck, the rotation of spine3 will be composed by the swing rotation and the twist rotation of neck.