Sanctum-Tokens fails if primary keys are not named `id`

JeffBeltran / sanctum-tokens

Simple Nova Plugin to generate a Laravel Sanctum Personal Access Token

https://novapackages.com/packages/jeffbeltran/sanctum-tokens

51 stars 27 forks source link

Sanctum-Tokens fails if primary keys are not named `id` #31

Closed tpetry closed 3 years ago

tpetry commented 3 years ago

The implementation has a hardcoded expectation on the naming of model primary keys which are changeable in eloquent. The proposed change makes the implementation adaptable to the changes done by developers by using eloquent's standard functions to operate on models.

JeffBeltran commented 3 years ago

hey @tpetry thanks for the PR, looks straight forward and will be a nice change. Let me check a few things and i'll get this merged in. thanks!

JeffBeltran commented 3 years ago

:tada: This PR is included in version 1.5.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: