search

JeffBeltran / sanctum-tokens

Simple Nova Plugin to generate a Laravel Sanctum Personal Access Token
https://novapackages.com/packages/jeffbeltran/sanctum-tokens
51 stars 27 forks source link

refactor(routes): Reorganize routes with a controller #33

Closed anibalsanchez closed 3 years ago

anibalsanchez commented 3 years ago

Hi,

I've refactored the routes with a controller. Now, it is possible to execute:

$ php artisan route:cache
Route cache cleared!
Routes cached successfully!

$ php artisan optimize
Configuration cache cleared!
Configuration cached successfully!
Route cache cleared!
Routes cached successfully!
Files cached successfully!

This improvement solved the issue #32

PS: I've also applied PSR2 styling to the files.

JeffBeltran commented 3 years ago

hey thanks for that @anibalsanchez i'll review this later today or tomorrow. i thought i had styling sorted out via husky but maybe not... either way im not concerned on that but i do want to ensure we are consistent across the package so PRs don't get cluttered with styling changes. TBH i didn't expect people to use this package and/or contribute to it so maybe i'll add styleci or something so we don't have to worry about this in the future. Thanks again!

JeffBeltran commented 3 years ago

:tada: This PR is included in version 1.5.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

JeffBeltran commented 3 years ago

Thanks @anibalsanchez for the contribution!