JeffBeltran / sanctum-tokens

Simple Nova Plugin to generate a Laravel Sanctum Personal Access Token
https://novapackages.com/packages/jeffbeltran/sanctum-tokens
51 stars 27 forks source link

Routes are not registered if Sanctum route registration is disabled #71

Open newock opened 2 years ago

newock commented 2 years ago

Now (in ToolServiceProvider.php):

if (
    $this->app->routesAreCached() ||
    false === config("sanctum.routes")
) {
    return;
}

Should be:

if ($this->app->routesAreCached()) {
    return;
}

I'd like to be able to have the plugin routes without including Sanctum ones.

JeffBeltran commented 2 years ago

Thanks for the feedback @newock, im not familiar with this, looking over the history im wondering if this was part of the tool generation feature. I'll take a look when i get time but i wouldn't expect that to be anytime soon.

Happy to accept a PR if you can give me a bit more info why that was there in the first place vs why it is no longer there. I prefer to keep things the "nova way" as much as possible to make things easier to maintain.