search

JeffBeltran / sanctum-tokens

Simple Nova Plugin to generate a Laravel Sanctum Personal Access Token
https://novapackages.com/packages/jeffbeltran/sanctum-tokens
51 stars 27 forks source link

fix: LoadingButton removed from nova core #93

Closed alancolant closed 1 year ago

alancolant commented 1 year ago

This PR reintroduces the LoadingButton component, which was removed from the core of Laravel Nova since version 4.28. Its absence prevented the submission of the creation modal.

This issue has been resolved by reintegrating the old component under a new name.

Fix issue #92

ralphschindler commented 1 year ago

This looks like a solid fix, thanks!

JeffBeltran commented 1 year ago

Thanks @alancolant looks good to me, i thought i saw on twitter they are going to release a UI kit, is that still the case? or was that a fever dream?

JeffBeltran commented 1 year ago

@alancolant if you can fix the commit message i'll get this merged asap, otherwise i will need to wait til after in the day when i get time. I really should add a contribution guide but... well time

juanr-yes commented 1 year ago

hope this gets solved soon! thanks for the effort guys

alancolant commented 1 year ago

@JeffBeltran commit message updated

galengidman commented 1 year ago

This is currently a blocker for us - would love to see this merged soon. Thanks all!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

galengidman commented 1 year ago

Thanks much @JeffBeltran and @alancolant

JeffBeltran commented 1 year ago

no problem, sorry it took me a bit to get it merged