search

JeffGarland / liaw2019-process

Repository for initial drafting of boost.process standards paper
MIT License
5 stars 4 forks source link

enhanced system -- should we remove? #18

Closed JeffGarland closed 5 years ago

JeffGarland commented 5 years ago

So this is an issue we discussed some in Aspen. I don't think we reached consensus on what to do about it. I'm seeing issues in the paper that Elias is taking but maybe that's due to not seeing that this is a new form?

Anyway my inclination is to add to open issues/help needed or remove altogether. Objections?

// EK: Change signature; system takes a string, not an argument pack template int system(Args&&... args) { // EK: Change constructor call to taking a path, arguments and something similar to s // EK: also, a rogue comma at the end process c(forward(args)...,); if (!c.valid()) return -1; c.wait(); return c.exit_code(); }

klemens-morgenstern commented 5 years ago

I think we should remove it and maybe even deprecate ‘std::system‘

JeffGarland commented 5 years ago

done. Changes pushed. I added a process_cuts.org file so we still have the text around in case we want it back.