search

JeffGarland / liaw2019-process

Repository for initial drafting of boost.process standards paper
MIT License
5 stars 3 forks source link

Alternative options in text for start_dir and process_io #20

Open JeffGarland opened 5 years ago

JeffGarland commented 5 years ago

// Provides an initializers for the standard io. Alternative: nested as std::process::io class process_io;

// Provides a way to set the starting directory of the new process. Alternative: nested as std::process::start_dir

What you have looks good to me - going to drop the alternative text.

JeffGarland commented 5 years ago

And on the start_dir did we discuss why we aren't just using filesystem::path?

JeffGarland commented 5 years ago

bc that's whats here:

requires ConvertibleTo<iter_value_t, string> explicit process(const filesystem::path& exe, const R& args, Inits&&... inits);

klemens-morgenstern commented 5 years ago

start_dir should take an fs::path, but should be a different type as to not be confused woth the executable.

JeffGarland commented 5 years ago

ok. So this has been excised from the proposal currently. After I did that I think I gained more understanding of the initializer. But inclined to leave it alone for now anyway