JeffGarland / liaw2019-process

Repository for initial drafting of boost.process standards paper
MIT License
5 stars 3 forks source link

LEWGI Cologne: Why don't write and read take a span? #33

Closed JeffGarland closed 5 years ago

JeffGarland commented 5 years ago

Elias has already solved this one in his push. read/write now take span. I'm adding the issue so I have a track of the LEWGI issues and their resolutions.

JeffGarland commented 5 years ago

@eliaskosunen I notice that your change did add some 'uncertainty' to the comments in the proposal like -- we should clarify that...

 // MutableBuffer?
  // ConstBuffer?
eliaskosunen commented 5 years ago

Yeah, those are concepts from the Networking TS. I'd say those comments can be removed now, though, as it seems like they'll be removed from the TS as well (from what I've heard).

JeffGarland commented 5 years ago

right -- I see we have this elsewhere too -- which could be an issue...

    // Read some data from the handle.
    // See the Networking TS for more details.
    template<class MutableBufferSequence>
    size_t read_some(const MutableBufferSequence& buffers);