Closed JeffGarland closed 4 years ago
// The destructor terminates ~process();
Feedback was clear on this point. std::thread was done wrong and that's part of the reason we have jthread now.
The logic of ~jthread amounts to checking if the thread is joinable and then calling request_stop() followed by join() on the thread.
So processes don't have join -- will just be wait, but could call wait.
Another option that was suggested was to call process::terminate on the child
So will make this an open issue for further committee discussion. As I see it the options are
Feedback was clear on this point. std::thread was done wrong and that's part of the reason we have jthread now.
The logic of ~jthread amounts to checking if the thread is joinable and then calling request_stop() followed by join() on the thread.
So processes don't have join -- will just be wait, but could call wait.
Another option that was suggested was to call process::terminate on the child
So will make this an open issue for further committee discussion. As I see it the options are