search

JeffGarland / range_by_example

range v3 example code
Boost Software License 1.0
23 stars 7 forks source link

Travis CI vs Wandbox.org? #1

Closed KjellKod closed 7 years ago

KjellKod commented 7 years ago

Hi Jeff,

This is not an "issue" but more a question regarding the feature request mention at today's library talk (c++now2017).

What was the proposition for using WandBox.org? Is it just to see if it runs and/or have unit tests? Maybe a travis integration would be enough? (ref: https://docs.travis-ci.com/user/getting-started)

I'm using travis CI for my g3log library and I'd be happy to make a pull request to your repo with a similar setup if that is what was requested.

Cheers Kjell

PS: Example output from Travis CI. Such a cloud CI run happens for every pull request to the repo.

KjellKod commented 7 years ago

Or was the intention more like this?: https://github.com/boost-experimental/di/blob/cpp14/README.md

JeffGarland commented 7 years ago

Yes — this is exactly the suggestion, thanks! Should be able to reverse engineer this….

On May 17, 2017, at 8:19 AM, Kjell Hedström notifications@github.com wrote:

Or was the intention more like this?: https://github.com/boost-experimental/di/blob/cpp14/README.md https://github.com/boost-experimental/di/blob/cpp14/README.md — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffGarland/range_by_example/issues/1#issuecomment-302124330, or mute the thread https://github.com/notifications/unsubscribe-auth/AEOOjlFW5tpg__g6M9eUMwaL8A3vQoPAks5r6xAFgaJpZM4Nd_6g.

JeffGarland commented 7 years ago

So we've got some examples running in Wandbox, but now that we're getting some real content here and Jeff Trull has coded a change to go more strict on warnings I think we might want to set this up. What would we need to do to setup Travis? I'll try to catch up with you today.

KjellKod commented 7 years ago

As agreed. I'll add Travis for gcc, with "catch" as unit test framework, update the CMake file to add a separate test executable.

Once that is reviewed and merged we can later, in other pull requests, add cloud CI for clang (Travis) and possibly for Windows too (appveyor)

JeffGarland commented 7 years ago

This is now setup and working -- so I'm closing the issue -- thanks for the contribution!