Thanks for the new diff @JeffLIrion . It looks good. Per your statement about other command IDs which don't read more data, in the adb source at the moment, that's only the family of stat commands (STAT, STA2 and LST2). Since adb-shell only supports STAT at the moment, the check currently implemented will be fine. Something worth keeping in mind if/when you think about support for things like statv2, shellv2 and friends :)
I don't have a device handy to sanity check this with, and won't be able to do so until Monday. However, FWICT the change looks good and I'm happy to give it :+1: for merge without that. I'll check back in on Monday and let you know how I go with the changeset up on this PR or with master if you merge it.
Thanks for the new diff @JeffLIrion . It looks good. Per your statement about other command IDs which don't read more data, in the adb source at the moment, that's only the family of stat commands (
STAT,STA2andLST2). Sinceadb-shellonly supportsSTATat the moment, the check currently implemented will be fine. Something worth keeping in mind if/when you think about support for things like statv2, shellv2 and friends :)I don't have a device handy to sanity check this with, and won't be able to do so until Monday. However, FWICT the change looks good and I'm happy to give it :+1: for merge without that. I'll check back in on Monday and let you know how I go with the changeset up on this PR or with master if you merge it.