JeffLIrion / adb_shell

A Python implementation of ADB with shell and FileSync functionality.
Apache License 2.0
530 stars 60 forks source link

Moved the metadata into `setup.cfg` #197

Open KOLANICH opened 2 years ago

KOLANICH commented 2 years ago

Added pyproject.toml. Version is now populated automatically from git tags using setuptools_scm. Deleted bumpversion.sh. Fixed some missing metadata fields.

JeffLIrion commented 2 years ago

I've never used a setup.cfg file before, what is the benefit over using setup.py?

Also, the CI checks did not pass.

KOLANICH commented 2 years ago

I've never used a setup.cfg file before, what is the benefit over using setup.py?

No strong benefits currently:

JeffLIrion commented 2 years ago

From some brief reading, it looks like pyproject.toml is the way of the future. So if you get the CI checks to pass and once I understand how it works, I'll merge this.

KOLANICH commented 2 years ago
  1. I have fixed the scripts to take the version from git tags and to update it. It will only work if there are commits upon the previous tag. Otherwise one should use the retag script.
  2. I have cleaned up the scripts a bit. Some used to be determining package name and then discarding it. That code has been removed.

I haven't used GitHub Actions to upload an artifact. What's the benefit of doing so?

Not really a strong benefit, but sometimes allows you to get the artifact build on the CI. Can have various uses, from not-building the package as a part of other CI pipelines and using the wheel, to troubleshooting the issues on CI.