Open KOLANICH opened 2 years ago
I've never used a setup.cfg
file before, what is the benefit over using setup.py
?
Also, the CI checks did not pass.
I've never used a setup.cfg file before, what is the benefit over using setup.py?
No strong benefits currently:
setup.cfg
+ pyproject.toml
, but it was discussed that the long-term goal is to eliminate package vendor-supplied code execution in this casesetup.cfg
will deprecated and its contents should be recommended to be moved into pyproject.toml
(currently there is no automatic convertor setup.cfg
-> pyproject.toml
, but it will be more automatic, more secure and more reliable because of more constrained and parseable structure of setup.cfg
, than setup.py
-> setup.cfg
, I guess even a bot automatically sending PRs will be possible).From some brief reading, it looks like pyproject.toml
is the way of the future. So if you get the CI checks to pass and once I understand how it works, I'll merge this.
retag
script.I haven't used GitHub Actions to upload an artifact. What's the benefit of doing so?
Not really a strong benefit, but sometimes allows you to get the artifact build on the CI. Can have various uses, from not-building the package as a part of other CI pipelines and using the wheel, to troubleshooting the issues on CI.
Added
pyproject.toml
. Version is now populated automatically from git tags usingsetuptools_scm
. Deletedbumpversion.sh
. Fixed some missing metadata fields.