search

JeffLIrion / python-androidtv

Communicate with an Android TV or Fire TV device via ADB over a network.
MIT License
160 stars 57 forks source link

Adding HBO, Hulu, Peacock, and Paramount+ #328

Closed sergeknystautas closed 1 year ago

sergeknystautas commented 1 year ago

While working on a different feature, I noticed several of my regular apps were not mapped to friendly names, so adding them.

JeffLIrion commented 1 year ago

This might lead to some edge case if a user configures com.hulu.livingroomplus to display as "Hulu" because both that and com.hulu.plus would display as "Hulu." But launching "Hulu" would open com.hulu.livingroomplus. I think it's OK, though.

https://github.com/home-assistant/core/blob/e3b81ad1701440b87c025ce5005027b396f51d81/homeassistant/components/androidtv/media_player.py#L283-L293

sergeknystautas commented 1 year ago

This might lead to some edge case if a user configures com.hulu.livingroomplus to display as "Hulu" because both that and com.hulu.plus would display as "Hulu." But launching "Hulu" would open com.hulu.livingroomplus. I think it's OK, though.

https://github.com/home-assistant/core/blob/e3b81ad1701440b87c025ce5005027b396f51d81/homeassistant/components/androidtv/media_player.py#L283-L293

Gotcha, yeah I wasn't sure if the names had to be unique. I was adding the (2) suffix to the names that seemed like duplicate to avoid that, but maybe that's not necessary.