search

JeffSteinbok / hass-dreo

Dreo Smart Device Integration for Home Assistant
MIT License
90 stars 28 forks source link

Initial support of Dreo heaters #71

Closed andy-cooper closed 4 months ago

andy-cooper commented 5 months ago

I modeled this as a Home Assistant climate device so that we can get some nice graphical thermostats. I did a little bit of refactoring of existing code to try to fit things into the same framework and make it a little more general - that work is incomplete.

This is largely functional against the one type of heater that I have - looking at Dreo's website, the other type of heaters look very similar, so I suspect that they should generally work if added to the supported models list.

In the spirit of giving, I thought I'd try to contribute this back to the community. Many thanks, @JeffSteinbok, for the work you did to get this off the ground. I doubt I would have tried to do this were it not for your earlier work.

andy-cooper commented 5 months ago

Don't merge this yet - it looks like there's an issue with it taking up 100% CPU of the homeassistant container. I need to debug it further ...

andy-cooper commented 5 months ago

OK, looks like I've fixed it. Go ahead and feel free to merge or not 😃

andy-cooper commented 5 months ago

Also, rather than double-posting the images - take a look at what I put into https://github.com/JeffSteinbok/hass-dreo/issues/61 to see the UX.

andy-cooper commented 4 months ago

@JeffSteinbok - I think I've addressed all the comments. LMK what you think at this point.

JeffSteinbok commented 4 months ago

Couple quick things, then good to go.

andy-cooper commented 4 months ago

Couple quick things, then good to go.

I don't see any more change requests than the ones I addressed (and the 2 about refactoring that I made a note on). All other things I fixed and resolved the conversation. Did you make extra comments/requests after that that I missed?

andy-cooper commented 4 months ago

@JeffSteinbok - can you take another look here; I think I addressed everything.

andy-cooper commented 4 months ago

Thanks!! I've got some more changes for oscillation support for heaters that I'll make a PR for in the next few days. And then I'll take a look at refactoring some stuff.