Closed JeffThorslund closed 3 years ago
I have been thinking about this and I came up with an idea. I asked my self, "Do our users really need to have an ability to add points to eddys?" Think about this for a minute.
Two points eddy can give you a circle, an oval/ellipse; Or even some more complex shapes.
Then three points can give you a heart shape or a moon shape: Four point will allow you to do a cross shape, five point - star shape.
That's great, but how many eddys are star shaped? I am not a kayaker, but my intuition says me that eddys are usually circles. In some cases hearts, right?
I think if we just make all eddys three pointed it would be more than enough. Users would be able to map any kind of eddy out.
Does it make sense?
Its a good thought. I think that the oval shape would cover about half of the use cases, but there are still lots of eddies that have strange complex oval-type shapes. Not necessarily "star" shapes with sharp points but smooth bean-like shapes. I thinks its important that the eddy is able to easily cover the entire eddy on the map, and not leave out sections of it because the user is unable to add more points.
We also already have a point adding function for the lines that we can use, it will just be a bit more complicated.
I still think being able to add and remove points is the way to go, we just need to find a way to make it intuive for the user, and intuitive for our code.
This will use similar reducers as the add/delete line point functionality, but will have to take into consideration a few extra cases.