fix bug in loop to add hits to wires list put the } at the right place.

JeffersonLab / HDGeant4

Geant4 simulation for the GlueX experiment

4 stars 4 forks source link

fix bug in loop to add hits to wires list put the } at the right place. #186

Closed zihlmann closed 3 years ago

zihlmann commented 3 years ago

second attempt to get this into the JeffersonLab GEANT4 repo master

rjones30 commented 3 years ago

I already merged these changes in, so the master branch contains this fix. Thank you for finding and fixing it!

markito3 commented 3 years ago

@rjones30 , Beni mistakenly submitted this pull request to the rjones30/HDGeant4 repository. You merged it in there. This is indeed the same pull request, a duplicate, but aimed at the JeffersonLab/HDGeant4 repository, which does not have the fix yet. I am re-opening it...

markito3 commented 3 years ago

but now there is a conflict, so I am confused...closing...

rjones30 commented 3 years ago

Mark, it is already done. The fix is in the master. -Richard

On Fri, Mar 12, 2021 at 4:36 PM Mark M. Ito @.***> wrote:

but now there is a conflict, so I am confused...closing...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/HDGeant4/pull/186#issuecomment-797769495, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3YKWAP5ACVH4UIZGIVBRDTDJ3OTANCNFSM4ZCUZPTA .