search

JeffersonLab / HDGeant4

Geant4 simulation for the GlueX experiment
4 stars 4 forks source link

Adjustments to makefile to work with new cmake system of Diracxx #193

Closed markito3 closed 2 years ago

markito3 commented 2 years ago

This is in addition to those in the previous commit from Richard.

I noticed that with Diracxx, using the new cmake system, if you specify

cmake -DCMAKE_INSTALL_PREFIX=$DIRACXX_HOME

then include, python, lib, etc. get installed into

$DIRACXX_HOME/x86_64

where I am assuming that "x86_64" is the output of "uname -p"

If this is the intended behavior, which I am assuming it is, then the make file for hdgeant4 has to modified with a path that includes "x86_64" to find include and lib.

Adds some logic to allow backward compatibility with old make system as well.

rjones30 commented 2 years ago

Mark, that is a bug. The symbol DIRACXX_HOME should point to the x86_64 directory, not its parent. I will fix this in my setup scripts and the HDGeant4 GNUmakefile as soon as you give me the green light.

-Richard Jones

On Sun, Aug 15, 2021 at 9:09 PM Mark M. Ito @.***> wrote:

This is in addition to those in the previous commit from Richard.

I noticed that with Diracxx, using the new cmake system, if you specify

cmake -DCMAKE_INSTALL_PREFIX=$DIRACXX_HOME

then include, python, lib, etc. get installed into

$DIRACXX_HOME/x86_64

where I am assuming that "x86_64" is the output of "uname -p"

If this is the intended behavior, which I am assuming it is, then the make file for hdgeant4 has to modified with a path that includes "x86_64" to find include and lib.

Adds some logic to allow backward compatibility with old make system as well.

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/HDGeant4/pull/193 Commit Summary

  • Adjustments to makefile to work with new cmake system of Diracxx in addition to those from the previous commit from Richard.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/HDGeant4/pull/193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3YKWFPRNZYV5HC6P5GCILT5BQNNANCNFSM5CGX4KWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

markito3 commented 2 years ago

GNUMakefile now assumes that it will find the include and lib directories under the DIRACXX_HOME directory. There is no mention of "x86_64" anymore with the latest changes to the Diracxx cmake system and invocation of same by Build Scripts.