Closed wdconinc closed 10 months ago
Hi @AyanRoy16 , I haven't looked through the recent parameter handling fixes you implemented, but that's where I would start. I don't think EICrecon does anything strange, so I expect this can be reproduced in a unit test.
https://github.com/JeffersonLab/JANA2/pull/244 is the one I'd bisect around (if I had the time)
Addressed in PR #257
With JANA2@master (1dc91585389da3ba96147a3fa203e6efae1a0471), the interpretation of the geometry parameter
dd4hep::xml_files
leads to duplication of the default value.Steps to reproduce
export DETECTOR_CONFIG=epic_craterlake
eicrecon sim_dis_18x275_minQ2=1000_craterlake.edm4hep.root
with that file from https://github.com/eic/EICrecon/actions/runs/6566489975Expected results
This should load geometry once.
Actual results
Tries (and fails) to load geometry twice (then 4 times, then 8 times, you get the idea).
Debugging
Info lines:
were added with
Relevant JANA2 calls at https://github.com/eic/EICrecon/blob/acts-upgrade-26/src/services/geometry/dd4hep/DD4hep_service.cc#L64-L84:
Passing
-Pdd4hep:xml_files=$DETECTOR_PATH/$DETECTOR_CONFIG.xml
works fine; it's just the defaults that are duplicated on parsing.