Closed nathanwbrei closed 3 months ago
This is because create_plugin()
has include_root=True
by default. We can change the default to false, then update the documentation to mention that there are different ways of calling it.
Side note: Even though lots of users will in principle need create_plugin()
, in practice none of them need what currently exists. EICrecon users mainly use plugins for organizing factories, and do their analysis downstream. Furthermore, EICrecon has a much more sophisticated CMake setup for JANA plugins which we may consider upstreaming. On the other hand, GlueX users at least do use plugins for different analyses, but they write all of their histograms to a single file, whereas our example writes a separate file for each analysis. Furthermore, I don't want to encourage people to use JGlobalRootLock, because we are moving towards a more declarative world, along the lines of JEventProcessorSequentialRoot.
Steps to reproduce:
jana-generate.py Plugin QuickTutorial
find_package(ROOT REQUIRED)
This defeats the purpose of the tutorial, which is to familiarize the user with JANA concepts without having them to install and invest in understanding ROOT