JeffersonLab / JANA2

Multi-threaded HENP Event Reconstruction
https://jeffersonlab.github.io/JANA2/
Other
6 stars 9 forks source link

355 jana1 2 documentation side menu #359

Closed DraTeots closed 2 months ago

DraTeots commented 2 months ago

I probably did something that hasn't been asked, please no offence here. But I just wanted to make it more accessible and easier to read.

DraTeots commented 2 months ago

I believe it makes https://github.com/JeffersonLab/JANA2/pull/356 obsolete. I saw it too late. Sorry.

DraTeots commented 2 months ago

image That is how it looks now (so you don't have to startup a local server)

nathanwbrei commented 2 months ago

While you are working on this, it looks like https://jeffersonlab.github.io/JANA2/#/tutorial is a broken link?

DraTeots commented 2 months ago

Ah... site deploys to github pages on each PR github actions run. That is not what we want. Fixed that. But the bright side is - you can see changes right now =)

But we WANT to merge this PR ASAP now.

DraTeots commented 2 months ago

While you are working on this, it looks like https://jeffersonlab.github.io/JANA2/#/tutorial is a broken link?

Fixed that. Worked on local machine because file system is case tolerant. It was Tutorial.md vs tutorial.md

nathanwbrei commented 2 months ago

If it makes your workflow faster, you can merge the documentation changes without waiting for all the other tests to complete

DraTeots commented 2 months ago

If it makes your workflow faster, you can merge the documentation changes without waiting for all the other tests to complete

I would prefer @RaiqaRasool to look at changes too. But I feel urgency to merge this PR to prevent security issue with any PR pushing changes to a website.

DraTeots commented 2 months ago

So, please, make another issue or PR if something is bad here.