search

JeffersonLab / JANA4ML4FPGA

EIC R&D supported project developing ML on FPGA for streaming readout systems
1 stars 1 forks source link

Problem in SingleEvioEventFileSource.cc #32

Closed cissieAB closed 1 year ago

cissieAB commented 1 year ago

https://github.com/JeffersonLab/JANA4ML4FPGA/blob/ee1fa8fe74523375170d21f4ecf0a35ed8862ec3/src/plugins/single_event_evio/SingleEvioEventFileSource.cc#L49-L52

@DraTeots

In the above lines, you bind buff to block.data, and block.data is set to be of length m_buff_len. But the useful data length is cur_len. The followed (m_buff_len-cur_len) data will be filled with 0. Then you pass this block with extra 0s to parser, the parser detect those 0s and complain "Unknown outer EVIO bank tag: 0".

If you really want to use this plugin, I think you should fix this and mark #31 as solved.

DraTeots commented 1 year ago

Oh! Good! Thanks! I will make a PR removing SingleEvioEventFileSource in favor of CDAQfile.