search

JeffersonLab / JANA4ML4FPGA

EIC R&D supported project developing ML on FPGA for streaming readout systems
1 stars 1 forks source link

Follow ODR rules #38

Open DraTeots opened 1 year ago

DraTeots commented 1 year ago

If sanitizers are enabled in CMake (see main CMake for commented)

#Add clang sanitizers
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
    # Enable sanitizers
    message(STATUS "Clang sanitizers are enabled")
    set(SANITIZE_FLAGS "-fsanitize=address,undefined")
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${SANITIZE_FLAGS}")
    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${SANITIZE_FLAGS}")
endif()

It shows lots of ODR violations mainly in evio parser and surrounding libs. Would be good to go over them

DraTeots commented 1 year ago

Related PR #21