search

JeffersonLab / analyzer

HallA C++ Analyzer
BSD 3-Clause "New" or "Revised" License
7 stars 54 forks source link

GenScaler changes broke TH{a/c}ScalerEvtHandler #124

Open sawjlab opened 7 years ago

sawjlab commented 7 years ago

In commit e86eb984812899e139983f97ee2e0cfbebb3c6aa I removed IsSLot from the Decode method in GenScaler.C. IsSlot is called instead in the LoadBank methods. This breaks THaScalerEvtHandler and THcScalerEvtHandler. IsSlot needs to be either put back in the Decode method, or the ScalerEvtHandler classes need to modified to make IsSlot calls to find the scaler headers. I prefer the latter.

I plan to modify the ScalerEvtHandler classes to walk through the bank structure and only examine data in UI4 banks.

sawjlab commented 7 years ago

I rewrote THcScalerEvtHandler a while ago to walk through the bank structure and only examine data in UI4 banks. THaScalerEvtHandler may remain broken.