search

JeffersonLab / analyzer

HallA C++ Analyzer
BSD 3-Clause "New" or "Revised" License
7 stars 54 forks source link

Changes to SConstruct, and configuration files to fix c++11 interpreter segfault #145

Closed brash99 closed 6 years ago

brash99 commented 6 years ago

There are three changes, only one of which probably relates to the segfault issue:

  1. Update the ROOT library definition in SConstruct to "root-config --glibs" to match Makefile definition.
  2. Update configuration files to properly pass the -DNDEBUG and -DWITH_DEBUG command line flags (again, consistent with Makefile).
  3. Update configuration files to add -fPIC to g++ command line flags specifically for the compilation of src/main.C ... this was not being done before, and is presumably the source of the segfault issue.
hansenjo commented 6 years ago

I can confirm that the segfault problems are gone now, at least as much as one can reasonably test by hand. Great job, Ed. The relevant changes have been merged in commit 20cf746. Closing this now.

hansenjo commented 6 years ago

OK, I didn't see the EVIO changes. I'll add them in a separate commit.

hansenjo commented 6 years ago

EVIO-related changes merged in commit 20cf746...89a98e4. Pull request fully merged now. Thanks again, Ed.