search

JeffersonLab / grapes

Data Analysis Framework based on CLARA
2 stars 17 forks source link

created 3 new wagons #24

Closed IzzyIllari closed 3 years ago

IzzyIllari commented 3 years ago

ep2gamma wagon ep6gamma wagon epPipPim2Gamma wagon searching for eta events

gavalian commented 3 years ago

It is generally very bad idea to name classes in Java with lower case. This can be a problem on some platforms.

gavalian commented 3 years ago

Since the code contains comments // Ask about this notation The notation is a convenient was of combining several particles in one loop without need of "if" statement. For example:

Particle get(Particle[] p, int[] signs){ Particle r = new Particle(); for(int i = 0; i < p.length; i++) r.combine(p[i],signs[i]); return r; }

IzzyIllari commented 3 years ago

It is generally very bad idea to name classes in Java with lower case. This can be a problem on some platforms.

Would it be sufficient to change the class names to be in all capital letters?

Since the code contains comments // Ask about this notation The notation is a convenient was of combining several particles in one loop without need of "if" statement. For example:

Particle get(Particle[] p, int[] signs){ Particle r = new Particle(); for(int i = 0; i < p.length; i++) r.combine(p[i],signs[i]); return r; }

Thank you for the information. I can remove those comments.

gavalian commented 3 years ago

There are no strict rules, Java suggests naming classes with first letter being Capital Letter. You can change the names to Ep2gamma or something like that, your choice.

IzzyIllari commented 3 years ago

There are no strict rules, Java suggests naming classes with first letter being Capital Letter. You can change the names to Ep2gamma or something like that, your choice.

Ok, I have changed the class names and removed the comments. From my end it appears that these commits have been added. Please let me know if I need to make any other changes or if these changes are not showing up for you.

gavalian commented 3 years ago

OK, the name changes worked. All merged.