JeffersonLab / halld_recon

Reconstruction for the GlueX Detector
6 stars 8 forks source link

Failed assertion in DCCALShower_factory.cc #793

Closed aaust closed 1 month ago

aaust commented 5 months ago

In rare but reproducible cases, hd_root fails with this message:

hd_root: libraries/CCAL/DCCALGeometry.cc:83: DVector2 DCCALGeometry::positionOnFace(int) const: Assertion `channel >= 0 && channel < m_numActiveBlocks' failed.

This example will reproduce it within 1000 events:

hd_root -PEVENTS_TO_SKIP=72000 -PNTHREADS=8 -PPLUGINS=compton /cache/halld/RunPeriod-2022-08/rawdata/Run111101/hd_rawdata_111101_016.evio

The failure originates in this line: https://github.com/JeffersonLab/halld_recon/blob/6efdd6be8da616f70a4e6ad9e0da598410884f89/src/libraries/CCAL/DCCALShower_factory.cc#L404-L405 where hitID has the value 329853489, far outside the allowed range.

aaust commented 3 months ago

With the current master branch, the error does no longer show up for this example. Will close the issue if the failure mode is no longer seen in a large-scale test, like a monitoring launch.

aaust commented 1 month ago

This error did not appear in 2022-08 monitoring launches ver18 or ver19. Consider it fixed.