search

JeffersonLab / halld_recon

Reconstruction for the GlueX Detector
6 stars 9 forks source link

Possible inconsistency in ECAL geometry implementation #806

Closed aaust closed 5 months ago

aaust commented 5 months ago

Since PR #804 , linking hdgeant4 against the halld_recon master fails with the following error messages:

In function `DEventSourceHDDM::Extract_DECALHit(hddm_s::HDDM*, jana::JFactory<DECALHit>*, std::string, jana::JEventLoop*)':
DEventSourceHDDM.cc:(.text+0x18395): undefined reference to `DECALGeometry::isBlockActive(int, int) const'
DEventSourceHDDM.cc:(.text+0x185c2): undefined reference to `DECALGeometry::isBlockActive(int, int) const'
DEventSourceHDDM.cc:(.text+0x185fe): undefined reference to `DECALGeometry::positionOnFace(int, int) const'
DEventSourceHDDM.cc:(.text+0x1877f): undefined reference to `DECALGeometry::positionOnFace(int, int) const'

and

 In function `DFactoryGenerator::GenerateFactories(jana::JEventLoop*)':
DFactoryGenerator.cc:(.text+0x58): undefined reference to `ECAL_init(jana::JEventLoop*)
somovalex commented 5 months ago

lECAL has to be added to the makefile in geant4

From: Alexander Austregesilo @.> Sent: Monday, April 22, 2024 3:04 PM To: JeffersonLab/halld_recon @.> Cc: Subscribed @.***> Subject: [EXTERNAL] [JeffersonLab/halld_recon] Possible inconsistency in ECAL geometry implementation (Issue #806)

Since PR #804https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_halld-5Frecon_pull_804&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=3GwSfXHuGUA7kD8lkua95gZYLR2gy7UZDuXh7yE3aFlhXKdSThrsQ93Mha15knA2&s=ieYC8AFRU4Zfj7EHEfINEyF_qOw3fesJ2GwhI8J63j4&e= , linking hdgeant4 against the halld_recon master fails with the following error messages:

In function DEventSourceHDDM::Extract_DECALHit(hddm_s::HDDM*, jana::JFactory<DECALHit>*, std::string, jana::JEventLoop*)': DEventSourceHDDM.cc:(.text+0x18395): undefined reference toDECALGeometry::isBlockActive(int, int) const' DEventSourceHDDM.cc:(.text+0x185c2): undefined reference to DECALGeometry::isBlockActive(int, int) const' DEventSourceHDDM.cc:(.text+0x185fe): undefined reference toDECALGeometry::positionOnFace(int, int) const' DEventSourceHDDM.cc:(.text+0x1877f): undefined reference to `DECALGeometry::positionOnFace(int, int) const'

and

In function DFactoryGenerator::GenerateFactories(jana::JEventLoop*)': DFactoryGenerator.cc:(.text+0x58): undefined reference toECAL_init(jana::JEventLoop*)

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_halld-5Frecon_issues_806&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=3GwSfXHuGUA7kD8lkua95gZYLR2gy7UZDuXh7yE3aFlhXKdSThrsQ93Mha15knA2&s=8TIg_vboQu5mtpOfAiWgQ7lJFYW_jR-_q_NWYBFPMc8&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD4KOG4IJHYBGGVUIASSG7TY6VNM7AVCNFSM6AAAAABGTLA2NGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TOMRWGYZDGMA&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=3GwSfXHuGUA7kD8lkua95gZYLR2gy7UZDuXh7yE3aFlhXKdSThrsQ93Mha15knA2&s=XqTTzvYwvab4D4OML5VobzsszJ0-QUXySwWo1OVTpGw&e=. You are receiving this because you are subscribed to this thread.Message ID: @.***>

aaust commented 5 months ago

The latest hdgeant4 PR fixed it: https://github.com/JeffersonLab/HDGeant4/pull/220