gluex
commented
3 months ago Test status for this pull request: SUCCESS
Summary: /work/halld/pull_request_test/halld_recon^andrsmit_ccalshower_062424/tests/summary.txt Logs: /work/halld/pull_request_test/halld_recon^andrsmit_ccalshower_062424/tests/log
Build log: /work/halld/pull_request_test/halld_recon^andrsmit_ccalshower_062424/make_andrsmit_ccalshower_062424.log Build report: /work/halld/pull_request_test/halld_recon^andrsmit_ccalshower_062424/report_andrsmit_ccalshower_062424.txt Location of build: /work/halld/pull_request_test/halld_recon^andrsmit_ccalshower_062424
igjaegle
The first and third commits are purely aesthetic changes to make all the code in the CCAL library use consistent tab characters for alignment. There were also some small changes (primarily in DCCALShower_factory.cc) to remove unnecessary and ugly white spaces). I also removed some non-useful comments and corrected the description of the 'address' used in the island clusterization code.
The second commit is the only functional change to the code. It corrects an issue in the CCAL shower factory where in rare cases an element beyond the range of a vector was attempting to be accessed (e.g. the 10th element of a vector with only 5 elements was trying to be accessed).