JeffersonLab / halld_sim

Simulation for the GlueX Experiment in Hall D
6 stars 10 forks source link

updates to FCAL hit smearing #296

Closed sdobbs closed 11 months ago

sdobbs commented 11 months ago

Add functionality to merge energy depositions in FCAL crystals and light guides for FCAL hits including scale factor between the two.

By default this behavior is enabled and the factor is pulled from the CCDB, but there are command line switches to modify this behavior as well.

gluex commented 11 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/tests/log

Build log: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/make_sdobbs_fcal_lightguide_updates.log Build report: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/report_sdobbs_fcal_lightguide_updates.txt Location of build: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates

gluex commented 11 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/tests/log

Build log: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/make_sdobbs_fcal_lightguide_updates.log Build report: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/report_sdobbs_fcal_lightguide_updates.txt Location of build: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates

markdalton commented 11 months ago

Maybe the message on line 241 of mcsmear.cc should indicate that the default is from CCDB?

gluex commented 11 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/tests/log

Build log: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/make_sdobbs_fcal_lightguide_updates.log Build report: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates/report_sdobbs_fcal_lightguide_updates.txt Location of build: /work/halld/pull_request_test/halld_sim^sdobbs_fcal_lightguide_updates