search

JeffersonLab / halld_sim

Simulation for the GlueX Experiment in Hall D
6 stars 10 forks source link

Update to timting resolution values #298

Closed KSaldan closed 11 months ago

KSaldan commented 11 months ago

The update allows an option to use the original 0.4 ns timing resolution or use an energy dependent timing resolution where the parameters were measured from a timing resolution experiment. The timing resolution is used in mcsmear.

gluex commented 11 months ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/make_FCAL_mcTimingSmearing_update.log Build report: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/report_FCAL_mcTimingSmearing_update.txt Location of build: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update

KSaldan commented 11 months ago

I fixed the error and the build compiles

sdobbs commented 11 months ago

if you push the fix to this branch, the test build will start again

sdobbs commented 11 months ago

Did you add the CCDB table to the master CCDB yet?

gluex commented 11 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/tests/log

Build log: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/make_FCAL_mcTimingSmearing_update.log Build report: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/report_FCAL_mcTimingSmearing_update.txt Location of build: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update

sdobbs commented 11 months ago

just one comment - the variable mc_config_t::FCAL_NEW_TIME_SMEAR needs to be given some default value. then you can have one command-line switch which toggles the value

gluex commented 11 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/tests/log

Build log: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/make_FCAL_mcTimingSmearing_update.log Build report: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/report_FCAL_mcTimingSmearing_update.txt Location of build: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update

gluex commented 11 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/tests/log

Build log: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/make_FCAL_mcTimingSmearing_update.log Build report: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update/report_FCAL_mcTimingSmearing_update.txt Location of build: /work/halld/pull_request_test/halld_sim^FCAL_mcTimingSmearing_update