JeffersonLab / halld_sim

Simulation for the GlueX Experiment in Hall D
6 stars 10 forks source link

Ksaldan gen amp v2 #338

Closed KSaldan closed 3 months ago

KSaldan commented 4 months ago

Added ability to add BW distribution for omega and phi particle if added in reaction.

gluex commented 4 months ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_sim^ksaldan_gen_amp_V2/tests/summary.txt Logs: /work/halld/pull_request_test/halld_sim^ksaldan_gen_amp_V2/tests/log

Build log: /work/halld/pull_request_test/halld_sim^ksaldan_gen_amp_V2/make_ksaldan_gen_amp_V2.log Build report: /work/halld/pull_request_test/halld_sim^ksaldan_gen_amp_V2/report_ksaldan_gen_amp_V2.txt Location of build: /work/halld/pull_request_test/halld_sim^ksaldan_gen_amp_V2

mashephe commented 3 months ago

I've looked through this PR and it looks good to me. Should we merge? I hesitated to merge myself because I'm an author. The big change is to add functionality that gets the mass variation correct for quasi-stable particles like omega, phi, etc.