search

JeffersonLab / hcana

Hall C++ Analyzer
7 stars 118 forks source link

SCons command-line flags not propagated into podd build #254

Open hansenjo opened 7 years ago

hansenjo commented 7 years ago

When using any type of command-line flag for scons to build hcana, these flags are apparently not used for building the podd submodul: Example:

scons -j8 debug=1

compiles podd sources like

c++ -o src/THaADCHelicity.os -c -O -Wall -Woverloaded-virtual -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -std=c++11 -m64 -pthread -rdynamic -fPIC -DNDEBUG -DLINUXVERS -DHAS_SSTREAM -I/home/ole/evio-4.4.6/Linux-x86_64/include -Isrc -Ihana_decode -I/opt/ROOT/6.10-04/include src/THaADCHelicity.C

but the hcana sources later like

g++ -o src/THcAerogel.os -c -g -O0 -Wall -Woverloaded-virtual -std=c++11 -m64 -pthread -rdynamic -fPIC -fPIC -DLINUXVERS -DHAS_SSTREAM -DHALLC_MODS -I/home/ole/evio-4.4.6/Linux-x86_64/include -Isrc -Ipodd/src -Ipodd/hana_decode -I/opt/ROOT/6.10-04/include src/THcAerogel.cxx

and the hcana build, but not the podd build, is very obviously parallelized.

brash99 commented 7 years ago

I think this one is related to the "new" way of building hcana, where instead of calling the podd SConscript.py, the Chana SConstruct now invokes the podd SConstruct directly.

Obviously I did not test this required functionality correctly.

I'll try to fix it.

Best,

E.

Dr. Edward J. Brash

Professor of Physics - Christopher Newport University

Staff Scientist - Thomas Jefferson National Accelerator Facility

Honorary Senior Research Fellow - University of Glasgow

Office: 757-594-7451 (tel:757-594-7451)

Mobile: 757-753-2831 (tel:757-753-2831)

FAX: 757-594-7919 (tel:757-594-7919)

On Sep 20, 2017 at 3:24 PM, <Ole Hansen (mailto:notifications@github.com)> wrote:

When using any type of command-line flag for scons to build hcana, these flags are apparently not used for building the podd submodul: Example:

scons -j8 debug=1

compiles podd sources like

c++ -o src/THaADCHelicity.os -c -O -Wall -Woverloaded-virtual -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -std=c++11 -m64 -pthread -rdynamic -fPIC -DNDEBUG -DLINUXVERS -DHAS_SSTREAM -I/home/ole/evio-4.4.6/Linux-x86_64/include -Isrc -Ihana_decode -I/opt/ROOT/6.10-04/include src/THaADCHelicity.C

but the hcana sources later like

g++ -o src/THcAerogel.os -c -g -O0 -Wall -Woverloaded-virtual -std=c++11 -m64 -pthread -rdynamic -fPIC -fPIC -DLINUXVERS -DHAS_SSTREAM -DHALLC_MODS -I/home/ole/evio-4.4.6/Linux-x86_64/include -Isrc -Ipodd/src -Ipodd/hana_decode -I/opt/ROOT/6.10-04/include src/THcAerogel.cxx

and the hcana build, but not the podd build, is very obviously parallelized.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_hcana_issues_254&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=QQI4wgZ48DvzGull4QAPAA&m=9YkTlWqnWuJkG8vTVGKLlDxX--8yRAOKtJKsoC3nqnw&s=GPBs1jU5ExH0A3pbTigxEVf0qioQvnnl5fkOlVvy8ts&e=), or mute the thread (https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AE1Pu1a7t9PgPgyLfAEs3okyVoEEGclsks5skWZ4gaJpZM4PeWug&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=QQI4wgZ48DvzGull4QAPAA&m=9YkTlWqnWuJkG8vTVGKLlDxX--8yRAOKtJKsoC3nqnw&s=vRmbw342UyF-8R5m-HtrmVfHVQrRDyux3VCEgnnVar4&e=).

sawjlab commented 5 years ago

Is this issue still an issue?

hansenjo commented 5 years ago

I don't think so. I think Ed fixed it quite a while ago.

Ole