JeffersonLab / hcana

Hall C++ Analyzer
7 stars 118 forks source link

Modify THcCherenkov.cxx and THcCherenkov.h #432

Closed MarkKJones closed 5 years ago

MarkKJones commented 5 years ago

Modify CoarseProcess so that if more than one hit in PMT is within the time window of the difference between pulse time and hodoscope start time the hit with the largest ADC value is selected as the good ADC hit for the PMT. Previously it used the last hit within the time window.

Before accepting would like others to test.

pooser commented 5 years ago

@MarkKJones The logic in the code to select the largest hit within the same time window is sound. Below I compare the total NPE distributions for both the SHMS HGC (first attachment) and NGC (second attachment) for before the change (red) and after the change (blue). The take home message is there is no enhancement at zero meaning we are not throwing anything away and that the modified manner in which we populate good variables is essentially unchanged as expected.

shms_hgcer_r2484

shms_ngcer_r2484