Warnings from THcTrigDet with ROOT 5

hansenjo commented 5 years ago

When compiling against ROOT 5 in /apps/root/5.34.21/root (which is what JLab CE 2.3 sets up), one gets warnings like the following from hcana:

src/THcTrigDet.cxx: In member function ‘virtual Int_t THcTrigDet::DefineVariables(THaAnalysisObject::EMode)’:
src/THcTrigDet.cxx:404:13: warning: extended initializer lists only available with -std=c++11 or -std=gnu++11 [enabled by default]
     RVarDef entry1 {
             ^

If this is to work with ROOT 5 (no C++11), it should be fixed. Or we finally drop support for ROOT 5.

hansenjo commented 5 years ago

Or we finally drop support for ROOT 5

On the other hand, the difference in startup times between hcana with ROOT 5 vs. hcana with ROOT 6 is truly astounding on ifarm (few seconds vs. about a minute).

MarkKJones commented 5 years ago

I vote we drop root 5 support

pooser commented 5 years ago

Considering that ROOT 5 reached its end of life some years ago, there is no reason to support it, in my opinion.

sawatzky commented 5 years ago

I agree -- we can ditch ROOT 5.

-- Brad

On Tue, 05 Feb 2019, Mark K Jones wrote:

I vote we drop root 5 support

-- You are receiving this because you are subscribed to this thread. Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.

References

Visible links

https://github.com/JeffersonLab/hcana/issues/433#issuecomment-460820306

https://github.com/notifications/unsubscribe-auth/AE85Ey3qx8Q88O_YEs7VdrgYb6SMkJnrks5vKf6WgaJpZM4aj7Iz

-- Brad Sawatzky, PhD brads@jlab.org -<>- Jefferson Lab / Hall C / C111 Ph: 757-269-5947 -<>- Fax: 757-269-5235 -<>- Pager: brads-page@jlab.org The most exciting phrase to hear in science, the one that heralds new discoveries, is not "Eureka!" but "That's funny..." -- Isaac Asimov

hansenjo commented 5 years ago

Sounds good - but FYI, that also means that hcana/podd won't work on RHEL 6 anymore (at least not without building ROOT there with a non-system compiler).

Ole

On 2/6/19 6:13 PM, Brad Sawatzky wrote:

I agree -- we can ditch ROOT 5.

-- Brad

brash99 commented 5 years ago

I feel like most people running EL6 systems are doing it for a good reason, and in those instances they are probably willing to accept this limitation. In other words, they probably have devtoolset-3 installed anyway and can compile ROOT with the upgraded compiler contained therein.

Cheers, E.

-- Dr. Edward J. Brash Professor of Physics - Christopher Newport University Staff Scientist - Thomas Jefferson National Accelerator Facility Honorary Senior Research Fellow - University of Glasgow Office: 757-594-7451 Mobile: 757-753-2831 FAX: 757-594-7919 On Feb 6, 2019, 7:22 PM -0500, Ole Hansen notifications@github.com, wrote:

Sounds good - but FYI, that also means that hcana/podd won't work on RHEL 6 anymore (at least not without building ROOT there with a non-system compiler).

Ole

On 2/6/19 6:13 PM, Brad Sawatzky wrote:

I agree -- we can ditch ROOT 5.

-- Brad

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

hansenjo commented 5 years ago

Agreed.

BTW, I was wrong, the JLab Common Environment sets up ROOT 6.14.04 by default, not ROOT 5. Hence we're definitely good on that front.

I'll make C++11 and ROOT 6 official prerequisites for Podd 1.7. Which means we can finally happily code away in C++11.

Ole

sawjlab commented 3 years ago

Seems like this issue should be closed.

JeffersonLab / hcana

Warnings from THcTrigDet with ROOT 5 #433