search

JeffersonLab / hcana

Hall C++ Analyzer
7 stars 118 forks source link

Firmware update #474

Closed sjdkay closed 2 years ago

sjdkay commented 2 years ago

Changes from the 2021/2022 PionLT run - Triggers were switched due to hardware changes. This is needed for coin time determination for the 2021 data onwards.

MarkKJones commented 2 years ago

Stephen, In the src/THcTrigDet.cxx, you do not need to change std::string trigNames as hardcoded. This can be done in the PARAM file. I would prefer to do it that way to keep the same hardcoded names. In the THcCoinTime class, I would prefer to replace "TRIG4" with "HMS" instead of "TRIG3". Then also replace "TRIG1" with "SHMS". I think that would make it slightly easier to read.

sjdkay commented 2 years ago

The switch to HMS/SHMS rather than Trig1/Trig3 definitely makes sense, that makes it more readable. I switched that around in the CoinTime class.

I also switched the names in THcTrigDet back. Out of curiosity, which param file would you recommend setting these in (and what would the required info look like in that file)?

sjdkay commented 2 years ago

Looks like I missed one of the variables to tweak so I corrected that, I also added in the raw untracked values to THcCoinTime since these weren't in this branch and I hadn't noticed.