search

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

remove wrong shim thickness and typo for top back UChannel #1001

Closed sarahgaiser closed 1 year ago

sarahgaiser commented 1 year ago

Removes 700um shift that Cam notices during his Survey Constant analysis and fixes bug in geometry code. The bug was as follows: by not setting the node for the top back alignment corrections, the corresponding survey volume had no access to the survey constants defined in the compact.xml. Fixing the typo solves this problem.

normangraf commented 1 year ago

Please hold off on merging this into master until we can discuss this at the software meeting. I would much prefer that we maintain backwards-compatibility with four years of simulation and reconstruction work. Changing the geometry in this way will invalidate those detectors. We should modify the compact.xml files to be commensurate with the new code such that the output geometry is unchanged. We should then proceed from here on out with new detectors that correct the mistake.