JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

Fix flags in the ReconParticleDriver clusterMatcher #1029

Open pbutti opened 4 months ago

pbutti commented 4 months ago

Currently the wrong flag is used to activate the cluster position corrections. The matcher uses the useTrackPositionClusterCorrection flag instead of useClusterCorrectionPosition. Matcher: https://outlook.office.com/mail/safelink.html?url=https://github.com/JeffersonLab/hps-java/blob/master/recon/src/main/java/org/hps/recon/utils/TrackClusterMatcherMinDistance.java#L129&corid=d5e86425-55a9-66d9-b160-1aac0dae1870 Called by: https://github.com/JeffersonLab/hps-java/blob/master/recon/src/main/java/org/hps/recon/particle/ReconParticleDriver.java#L524

Is this intended ? @alspellm @sarahgaiser @mholtrop

pbutti commented 3 months ago

ping: @alspellm @sarahgaiser @mholtrop

sarahgaiser commented 3 months ago

I don't know much about this. What do you want me to check here?