Move the track extrapolation from dipole edge to z=800

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java

2 stars 10 forks source link

Move the track extrapolation from dipole edge to z=800 #1030

Closed pbutti closed 5 months ago

pbutti commented 5 months ago

This should fix #1026 @mholtrop

mholtrop commented 5 months ago

One of the tests is failing

Error: PhysRun2016V0ReconTest>ReconTest.testRecon:380->ReconTest.comparePlots:252->ReconTest.compareTrees:272->ReconTest.compareHistograms:293 Bin 12 is different for: V0 Bottom Track Momentum expected:<241> but was:<240>

So that is because our tests are not very smart and do not permit improvements of the code.

pbutti commented 5 months ago

@mholtrop Can we change the reference with the new file?

mholtrop commented 5 months ago

Can we change the reference with the new file?

We should be able to, I think. I know how though.

pbutti commented 5 months ago

This PR is linked to #1031

cbravo135 commented 5 months ago

Just want to point out that there isn't a need to request changes when a test is failing since that already blocks the merge anyway.

cbravo135 commented 5 months ago

I updated the reference file, the tests are all passing for this branch now.