search

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

adding overlay for 2016 #1039

Open sarahgaiser opened 4 months ago

tongtongcao commented 4 months ago

Thanks for the nice work.

Here are my comments for coding: Basically, the updates are for application of 2016 DAQ configuration in the new digitization system. So Similar updates can be taken as PR#1019 for the updates for application of 2016 DAQ configuration.

1) For EcalDigitizationWithPulserDataMergingReadout2016Driver.java, do not need to add this new driver. Instead, you can update EcalDigitizationWithPulserDataMergingReadoutDriver.java. Refer to driver for how to do updates.

2) For the new steering file, since DAQ configuration is applied, parameters for digitization and trigger system are loaded from the DAQ configuration and they are run dependent, so do not set them in the steering file. Refer to steering file

tongtongcao commented 4 months ago

Looks fine for me. But validation is needed before approval. Keep one thing in mind: According to experience of 2019&2021, peak for delta_time between track and cluster might change due to the new readout system. So \<trackClusterTimeOffset>36.8\</trackClusterTimeOffset> in reconstruction steering files might need to be updated.