JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

Add Simple Unit Test of EVIO to LCIO Conversion #483

Closed JeremyMcCormick closed 5 years ago

JeremyMcCormick commented 5 years ago

Read in EVIO files with 2015, 2016 and 2019 data, convert to LCIO, and check the output.

Initial check could just be that collections are not empty, the expected number of objects are there (this will help for testing in case an EVIO reader is reading the wrong collection and creating too many objects), and the data fields have non-zero values, for ADC counts, for instance.

This test could be added on iss434 where the Hodoscope converter is being developed.

omar-moreno commented 5 years ago

For SVT, two test exist. SvtEvioReader for 2015/2016 data and Phys2019SvtEvioReader for 2019 data.

JeremyMcCormick commented 5 years ago

I think for now the recon tests cover this sufficiently as they run from EVIO data.