search

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

LCSimTestRunEventBuilder should not contain ANY 2019 processing classes. #543

Closed mholtrop closed 3 years ago

mholtrop commented 5 years ago

We should not have hodoscope or VTP ( or TS) processors in the LCSimTestRunEventBuilder base class.

This is an intermediate step issue. Eventually, we need to rip the entire LCSimTestRunEventBuilder out of the class chain, but that is a separate step for later.

Right now, new processors for EVIO banks that do not exist in the 2015/16 dataset should be added to the new LCSimPhys2019EventBuilder, and no where else.

NOTE -- This issue is to be merged with the Run2019Master - not with master.

JeremyMcCormick commented 5 years ago

There's 2015 and 2016 stuff in there too. 😆

JeremyMcCormick commented 3 years ago

This has been renamed as "Base" instead of "TestRun" via a recent PR - please open an additional issue if further changes are desired.