search

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

Add tanLambda cuts #939

Closed sarahgaiser closed 1 year ago

sarahgaiser commented 1 year ago

work in progress

pbutti commented 1 year ago

Hi Sarah, the cuts should be done at track reconstruction level instead at plotting level. Making cuts at track reconstruction level (i.e. SimpleGBLTrajAliDriver) would harmonize what is used for alignment and what is used for monitoring. In fact the tanLambda cuts can already be applied at that stage see: https://github.com/JeffersonLab/hps-java/blob/master/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java#L352

cbravo135 commented 1 year ago

Hi PF, there are times when I personally run GBLOutputDriver and not SimpleGBLTrajAliDriver, and would like to be able to have these kinds of cuts possible there too.

pbutti commented 1 year ago

Is it clear why CI fails?

cbravo135 commented 1 year ago

Relaunched CI and they passed. @pbutti