remove odd-number-hit cut for Kalman tracks

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java

2 stars 10 forks source link

remove odd-number-hit cut for Kalman tracks #945

Closed tomeichlersmith closed 1 year ago

tomeichlersmith commented 1 year ago

This was a relic of a time when we were comparing KF-based and ST-based alignments. It is not needed anymore and we should remove this cut so we can use all tracks found by KF, including ones that may have only one sensor from a given module.

Still To Do

[ ] Check that this does not break previous alignment studies
[ ] Maybe see if it helps?
[ ] Maybe change the meaning of the nhit cut as described in #944

pbutti commented 1 year ago

@tomeichlersmith Status of this? Still WIP ?

tomeichlersmith commented 1 year ago

I just haven't tested it - it compiles and runs normally if you want to just risk it.

pbutti commented 1 year ago

ok. LGTM