search

JeffersonLab / hps-java

HPS reconstruction and analysis framework in Java
2 stars 10 forks source link

Update value of BeamLineConstants.ECAL_FACE #952

Closed normangraf closed 1 year ago

normangraf commented 1 year ago

The calorimeter was moved downstream for the 2019 and 2021 runs, but the value of ECAL_FACE in tracking/src/main/java/org/hps/recon/tracking/BeamlineConstants.java was not updated. This means that when comparing the track state as returned by TrackStateUtils.getTrackStateAtECal(track) to the cluster position as returned by cluster.getPosition() they are at very different z locations:

EcalFaceZPosition

This had been fixed in git branch iss914, but was not merged into the master branch before that issue was closed.

normangraf commented 1 year ago

The tracking code will have to be modified to reference ECAL_FACE_ENGINEERING_RUNS when reconstructing data from 2015 and 2016.

normangraf commented 1 year ago

Other variables in BeamlineConstants should be reviewed and updated as necessary for the 2019 and 2021 runs.